[CL] chore: abstract module package from keeper #4075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:app-wiring
stackman27
requested review from
czarcas7ic,
p0mvn,
mattverse and
AlpinYukseloglu
mattverse
reviewed
Jan 22, 2023
Comment on lines
11
to
13
|
|
||
| func RandomMsgCreateConcentratedPool(k clkeeper.Keeper, sim *osmosimtypes.SimCtx, ctx sdk.Context) (*clmodeltypes.MsgCreateConcentratedPool, error) { | ||
| return nil, nil |
There was a problem hiding this comment.
can we have lints fixed for this?
p0mvn
approved these changes
Jan 23, 2023
p0mvn
added
the
V:state/compatible/no_backport
pysel
pushed a commit
that referenced
this pull request
Jan 23, 2023
* module package abstracted * fixed linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Abstracts the module package from keeper. Preparation for simulator testing
Brief Changelog
n/a
Testing and Verifying
n/a
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)